Skip to content

(GitHub Sort Reactions) Suggestion: collapse out of view the block of buttons when mouseaway. In such case, display the active sort icon next to the two-triangles icon #39

Closed
@darkred

Description

@darkred

@Mottie First of all, thanks a lot for this great script!
I was wondering whether it's possible to make a script to sort the comments based on the reactions in a practical way ! You really nailed it, once again! 👏


I just have one suggestion, please:

Currently, having two rows of button blocks (one of the post itself and the second by the script)
makes it distracting and difficult for me to visually distinguish them.

My suggestion is to collapse out of view (- in a similar way to that of your script "GitHub Reveal Header"- maybe collapse the block by temporarily converting it to a thin line/separator) the block of buttons on mouseaway from that element. And:

  • when a sort button is active and the block of buttons is collapsed on mouseaway,
    to display the currently active sort icon and its order (i.e. create an extra icon) next to the two-triangles icon.
  • when no sort is active, remove that extra icon.

Please see my mockup below to better see what I mean.

I know the script in it's initial version - I just wanted to post my suggestion and I hope you like it. 🙂

Example screenshot:
2018-02-28_193405
And a mockup:
2018-02-28_194332

PS. I've tried implementing my suggestion myself but unfortunately it seems too difficult for me, that's why I didn't provide a PR instead.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions