Skip to content

feat: iOS SDK 11.5+, Android SDK 33.13+ #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
- [@nativescript/firebase-admob](packages/firebase-admob/README.md)
- [@nativescript/firebase-analytics](packages/firebase-analytics/README.md)
- [@nativescript/firebase-app-check](packages/firebase-app-check/README.md)
- [@nativescript/firebase-app-check-debug](packages/firebase-app-check-debug/README.md)
Expand Down
1 change: 0 additions & 1 deletion apps/demo-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"@nativescript/firebase-database": "file:../../dist/packages/firebase-database",
"@nativescript/firebase-firestore": "file:../../dist/packages/firebase-firestore",
"@nativescript/firebase-analytics": "file:../../dist/packages/firebase-analytics",
"@nativescript/firebase-admob": "file:../../dist/packages/firebase-admob",
"@nativescript/firebase-crashlytics": "file:../../dist/packages/firebase-crashlytics",
"@nativescript/firebase-app-check": "file:../../dist/packages/firebase-app-check",
"@nativescript/firebase-remote-config": "file:../../dist/packages/firebase-remote-config",
Expand Down
45 changes: 14 additions & 31 deletions apps/demo-angular/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,8 @@
"production": true,
"uglify": true,
"release": true,
"forDevice": true
},
"dependsOn": [
{
"target": "build.all",
"dependencies": true
}
]
},
"ios": {
"executor": "@nativescript/nx:build",
"options": {
"platform": "ios",
"noHmr": true
},
"dependsOn": [
{
"target": "build.all",
"dependencies": true
}
]
},
"android": {
"executor": "@nativescript/nx:build",
"options": {
"platform": "android",
"noHmr": true
"forDevice": true,
"tsConfig": "apps/demo-angular/tsconfig.json"
},
"dependsOn": [
{
Expand All @@ -48,13 +23,21 @@
]
},
"clean": {
"executor": "@nativescript/nx:build",
"options": {
"clean": true
}
"executor": "@nativescript/nx:clean",
"options": {}
},
"lint": {
"executor": "@nx/eslint:lint"
},
"debug": {
"executor": "@nativescript/nx:debug",
"options": {
"noHmr": true,
"uglify": false,
"release": false,
"forDevice": false,
"prepare": false
}
}
}
}
1 change: 0 additions & 1 deletion apps/demo-angular/src/app-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { HomeComponent } from './home.component';
const routes: Routes = [
{ path: '', redirectTo: '/home', pathMatch: 'full' },
{ path: 'home', component: HomeComponent },
{ path: 'firebase-admob', loadChildren: () => import('./plugin-demos/firebase-admob.module').then((m) => m.FirebaseAdmobModule) },
{ path: 'firebase-analytics', loadChildren: () => import('./plugin-demos/firebase-analytics.module').then((m) => m.FirebaseAnalyticsModule) },
{ path: 'firebase-app-check', loadChildren: () => import('./plugin-demos/firebase-app-check.module').then((m) => m.FirebaseAppCheckModule) },
{ path: 'firebase-app-check-debug', loadChildren: () => import('./plugin-demos/firebase-app-check-debug.module').then((m) => m.FirebaseAppCheckDebugModule) },
Expand Down
3 changes: 0 additions & 3 deletions apps/demo-angular/src/home.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ import { Component } from '@angular/core';
})
export class HomeComponent {
demos = [
{
name: 'firebase-admob',
},
{
name: 'firebase-analytics',
},
Expand Down

This file was deleted.

19 changes: 0 additions & 19 deletions apps/demo-angular/src/plugin-demos/firebase-admob.component.ts

This file was deleted.

10 changes: 0 additions & 10 deletions apps/demo-angular/src/plugin-demos/firebase-admob.module.ts

This file was deleted.

2 changes: 0 additions & 2 deletions apps/demo-angular/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
"@nativescript/firebase-database": ["packages/firebase-database/index.d.ts"],
"@nativescript/firebase-firestore": ["packages/firebase-firestore/index.d.ts"],
"@nativescript/firebase-analytics": ["packages/firebase-analytics/index.d.ts"],
"@nativescript/firebase-admob": ["packages/firebase-admob/index.d.ts"],
"@nativescript/firebase-admob/angular": ["packages/firebase-admob/angular/index.ts"],
"@nativescript/firebase-crashlytics": ["packages/firebase-crashlytics/index.d.ts"],
"@nativescript/firebase-app-check": ["packages/firebase-app-check/index.d.ts"],
"@nativescript/firebase-remote-config": ["packages/firebase-remote-config/index.d.ts"],
Expand Down
4 changes: 0 additions & 4 deletions apps/demo-vue/app/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ import '@nativescript/firebase-performance';
import '@nativescript/firebase-remote-config';
import '@nativescript/firebase-storage';

import { Admob } from '@nativescript/firebase-admob';

import { AppCheck } from '@nativescript/firebase-app-check-debug';
import { Application } from '@nativescript/core';

Expand All @@ -35,8 +33,6 @@ firebase()
firebase().crashlytics().setCrashlyticsCollectionEnabled(true);
});

Admob.init();

const dynamicLinks = firebase().dynamicLinks();

dynamicLinks.onLink((link) => {
Expand Down
8 changes: 0 additions & 8 deletions apps/demo-vue/app/components/Home.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

<script lang="ts">
import Vue from 'nativescript-vue';
import Admob from '../plugin-demos/firebase-admob.vue';
import Analytics from '../plugin-demos/firebase-analytics.vue';
import AppCheck from '../plugin-demos/firebase-app-check.vue';
import AppCheckDebug from '../plugin-demos/firebase-app-check-debug.vue';
Expand All @@ -38,10 +37,6 @@ import RemoteConfig from '../plugin-demos/firebase-remote-config.vue';
import Storage from '../plugin-demos/firebase-storage.vue';

const routes = [
{
name: 'firebase-admob',
detail: Admob,
},
{
name: 'firebase-analytics',
detail: Analytics,
Expand Down Expand Up @@ -129,9 +124,6 @@ export default Vue.extend({
},
demos() {
return [
{
name: 'firebase-admob',
},
{
name: 'firebase-analytics',
},
Expand Down
34 changes: 0 additions & 34 deletions apps/demo-vue/app/plugin-demos/firebase-admob.vue

This file was deleted.

1 change: 0 additions & 1 deletion apps/demo-vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"description": "NativeScript Application",
"dependencies": {
"@nativescript/core": "file:../../node_modules/@nativescript/core",
"@nativescript/firebase-admob": "file:../../packages/firebase-admob",
"@nativescript/firebase-analytics": "file:../../dist/packages/firebase-analytics",
"@nativescript/firebase-app-check": "file:../../packages/firebase-app-check",
"@nativescript/firebase-auth": "file:../../packages/firebase-auth",
Expand Down
45 changes: 14 additions & 31 deletions apps/demo-vue/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,33 +11,8 @@
"production": true,
"uglify": true,
"release": true,
"forDevice": true
},
"dependsOn": [
{
"target": "build.all",
"dependencies": true
}
]
},
"ios": {
"executor": "@nativescript/nx:build",
"options": {
"platform": "ios",
"noHmr": true
},
"dependsOn": [
{
"target": "build.all",
"dependencies": true
}
]
},
"android": {
"executor": "@nativescript/nx:build",
"options": {
"platform": "android",
"noHmr": true
"forDevice": true,
"tsConfig": "apps/demo-vue/tsconfig.json"
},
"dependsOn": [
{
Expand All @@ -47,13 +22,21 @@
]
},
"clean": {
"executor": "@nativescript/nx:build",
"options": {
"clean": true
}
"executor": "@nativescript/nx:clean",
"options": {}
},
"lint": {
"executor": "@nx/eslint:lint"
},
"debug": {
"executor": "@nativescript/nx:debug",
"options": {
"noHmr": true,
"uglify": false,
"release": false,
"forDevice": false,
"prepare": false
}
}
}
}
2 changes: 0 additions & 2 deletions apps/demo-vue/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
"@nativescript/firebase-database": ["../../packages/firebase-database/index.d.ts"],
"@nativescript/firebase-firestore": ["../../packages/firebase-firestore/index.d.ts"],
"@nativescript/firebase-analytics": ["../../packages/firebase-analytics/index.d.ts"],
"@nativescript/firebase-admob": ["../../packages/firebase-admob/index.d.ts"],
"@nativescript/firebase-admob/angular": ["../../packages/firebase-admob/angular/index.ts"],
"@nativescript/firebase-crashlytics": ["../../packages/firebase-crashlytics/index.d.ts"],
"@nativescript/firebase-app-check": ["../../packages/firebase-app-check/index.d.ts"],
"@nativescript/firebase-remote-config": ["../../packages/firebase-remote-config/index.d.ts"],
Expand Down
9 changes: 4 additions & 5 deletions apps/demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
"repository": "<fill-your-repository-here>",
"dependencies": {
"@nativescript/core": "file:../../node_modules/@nativescript/core",
"@nativescript/firebase-admob": "file:../../packages/firebase-admob",
"@nativescript/firebase-analytics": "file:../../dist/packages/firebase-analytics",
"@nativescript/firebase-app-check": "file:../../packages/firebase-app-check",
"@nativescript/firebase-app-check-debug": "file:../../packages/firebase-app-check-debug",
"@nativescript/firebase-auth": "file:../../packages/firebase-auth",
"@nativescript/firebase-core": "file:../../packages/firebase-core",
"@nativescript/firebase-crashlytics": "file:../../packages/firebase-crashlytics",
Expand All @@ -18,13 +18,12 @@
"@nativescript/firebase-in-app-messaging": "file:../../packages/firebase-in-app-messaging",
"@nativescript/firebase-installations": "file:../../packages/firebase-installations",
"@nativescript/firebase-messaging": "file:../../packages/firebase-messaging",
"@nativescript/firebase-messaging-core": "file:../../packages/firebase-messaging-core",
"@nativescript/firebase-performance": "file:../../packages/firebase-performance",
"@nativescript/firebase-remote-config": "file:../../packages/firebase-remote-config",
"@nativescript/firebase-storage": "file:../../packages/firebase-storage",
"@nativescript/google-signin": "~2.1.0",
"@nativescript/firebase-app-check-debug": "file:../../packages/firebase-app-check-debug",
"@nativescript/firebase-messaging-core": "file:../../packages/firebase-messaging-core",
"@nativescript/firebase-ui": "file:../../packages/firebase-ui"
"@nativescript/firebase-ui": "file:../../packages/firebase-ui",
"@nativescript/google-signin": "~2.1.0"
},
"devDependencies": {
"@nativescript/android": "~8.8.0",
Expand Down
45 changes: 14 additions & 31 deletions apps/demo/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,8 @@
"production": true,
"uglify": true,
"release": true,
"forDevice": true
},
"dependsOn": [
{
"target": "build.all",
"dependencies": true
}
]
},
"ios": {
"executor": "@nativescript/nx:build",
"options": {
"platform": "ios",
"noHmr": true
},
"dependsOn": [
{
"target": "build.all",
"dependencies": true
}
]
},
"android": {
"executor": "@nativescript/nx:build",
"options": {
"platform": "android",
"noHmr": true
"forDevice": true,
"tsConfig": "apps/demo/tsconfig.json"
},
"dependsOn": [
{
Expand All @@ -48,13 +23,21 @@
]
},
"clean": {
"executor": "@nativescript/nx:build",
"options": {
"clean": true
}
"executor": "@nativescript/nx:clean",
"options": {}
},
"lint": {
"executor": "@nx/eslint:lint"
},
"debug": {
"executor": "@nativescript/nx:debug",
"options": {
"noHmr": true,
"uglify": false,
"release": false,
"forDevice": false,
"prepare": false
}
}
}
}
Loading