added support for dns.he.net certbot plugin #2153

[benhubert]

No description provided.

[nginxproxymanagerci]

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-2924

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

[benhubert]

I tested it with one of my personal top level domains + wildcard subdomain (such as example.com,*.example.com) using jc21/nginx-proxy-manager:github-pr-2924 docker image and this worked ✔️

I also tried to get a certificate for a subdomain but sadly this does not work. ❌
I found tsaaristo/certbot-dns-he#3 and tsaaristo/certbot-dns-he#2 waiting for an answer of the maintainer since 2020 😒

[amartins]

@benhubert I attempted to retrieve your image from DockerHub. However, I noticed that Hurricane Electric is not listed in the DNS Provider's dropdown menu.

Here's my docker-compose.yml file:

version: '3.8'
services:
  app:
    image: 'jc21/nginx-proxy-manager:github-pr-2924'
    restart: unless-stopped
    ports:
      - '80:80'
      - '81:81'
      - '443:443'
    volumes:
      - ./data:/data
      - ./letsencrypt:/etc/letsencrypt`

am I doing anything wrong?

[rlcranney]

I also installed the image 'jc21/nginx-proxy-manager:github-pr-2924' and also don't see Hurricane Electric in the drop down list.
Here is my docker compose file

Here is a screenshot of the DNS Provider's dropdown box.

[rlcranney]

@benhubert I downloaded your pull request and noticed that on row 295, the password variable has spaces in it.
I am definitely a newb when it comes to coding, but instead of my HE password, did you mean to write my_HE_password ?

If I am off the mark, please know my intent it to get this resolved. I am trying to be helpful, as I would really like Hurricane Electric to be a supported DNS Provider in NPM.

I doubt this is what is keeping Hurricane Electric from appearing on the list, but thought I would inquire in case it is an issue.

@jc21 I don't know if requires verification label is an indication that you have to do something or a call for others to test / validate? Is there anything I can do that will assist?

[benhubert]

Just tested again on a new machine and it works for me. Maybe you need to full-reload the UI? I used the following docker-compose.yml:

version: '3.8'
services:
  app:
    image: 'jc21/nginx-proxy-manager:github-pr-2924'
    restart: unless-stopped
    ports:
      - '80:80'
      - '81:81'
      - '443:443'
    volumes:
      - ./data:/data
      - ./letsencrypt:/etc/letsencrypt

But nevertheless, this is pretty useless in my eyes as long as certbot-dns-he does not support subdomains.

@rlcranney The spaces are part of the sample password. This is just an example line that needs to be replaced in the UI by the user. See this screenshot for better understanding:

[jc21]

@rlcranney the label means someone, me or anyone, needs to test though in the case of the DNS providers, I don't use most of them so I rely on the community to test.

I'll merge this anyway, should it not work as intended, users can always roll back.