swap mysql library and knex client for mysql2 #3991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MySQL 9 the use of the native_password plugin is no longer supported and caching_sha2_password is now required.
Currently npm makes use of the mysql library. This library unfortunately does not support the caching_sha2_password authentication method.
mysql2 supports the new caching_sha2_password methods and "is mostly API compatible with Node MySQL and supports majority of features"
This PR changes the mysql library for mysql 2 and updates the knex configs to use mysql2. This closes issue #3287
Basic tests against a new and existing npm database (updated to mysql 9) worked flawlessly.
I might be doing something wrong, but I was not able to get the scripts/test_dev.sh to run as it was seeking a taskfile in the dev container.