Skip to content

Ignore default location when defined in advanced config #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

jc21
Copy link
Member

@jc21 jc21 commented Feb 21, 2019

Fixes #65 by ignoring the built-in default location when it's detected in the advanced configuration.

In essence, the regex searches for location / { in many forms.

@jc21
Copy link
Member Author

jc21 commented Feb 21, 2019

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-79

@kolbii
Copy link
Contributor

kolbii commented Feb 21, 2019

Good idea.
I use the config block a lot but I'm feeling bad while I'm working on configuring. (indent, highlight, etc)
Wouldn't CodeMirror be good stuff instead of simple textarea?

@jc21 jc21 merged commit e7379e3 into develop Feb 25, 2019
kolbii pushed a commit to kolbii/nginx-proxy-manager that referenced this pull request Feb 25, 2019
@jc21 jc21 deleted the feature/65-advanced_default_location branch January 22, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants