Skip to content

Update _hsts.conf template to increase HSTS max-age value #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

phantomski77
Copy link
Contributor

I propose the change of max-age value of HSTS from 1 year to 2 years in accordance with Mozilla recommended configurations for Security/Server side TLS.

  • Recommended by Mozilla and security whitepapers
  • Server side setting not affecting clients
  • Security hardening principle
  • 1 year fails most SSL checks
    If variable value is necessary, I'd suggest an extra option in Proxy Host/SSL section in WebGUI.

Thank you and keep up the great work.

I propose the change to max-age value of HSTS from 1 year to 2 years.
@jc21
Copy link
Member

jc21 commented Mar 15, 2021

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-947

@phantomski77
Copy link
Contributor Author

Pulled, tested, all correct. Container /app/templates/_hsts.conf modified and used correctly by certbot. Resulting SSL protocol details using correct new HSTS value.

Thanks @jc21, much appreciated.

@jc21 jc21 changed the base branch from master to develop March 16, 2021 09:47
@jc21
Copy link
Member

jc21 commented Mar 16, 2021

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-947

@jc21 jc21 merged commit b7fb2cf into NginxProxyManager:develop Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants