Dr satyr/issue346 #769
Merged
Dr satyr/issue346 #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds tests to cover issue #346 by verifying the handling of required property changes in both request and response schemas.
- Added a new test method requiredPropertyChangedTest in SchemaDiffTest.java to verify required property changes.
- Introduced a helper method getResponseBodyChangedSchema in ChangesResolver.java to support response schema diffing for the new test.
- Removed an outdated multipleOf compatibility assertion as part of the schema change verification.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/src/test/java/org/openapitools/openapidiff/core/SchemaDiffTest.java | Added tests for required property changes and removed an obsolete multipleOf compatibility check. |
| core/src/test/java/org/openapitools/openapidiff/core/ChangesResolver.java | Introduced a new helper method to obtain response schema changes to support the added tests. |
Files not reviewed (2)
- core/src/test/resources/schemaDiff/required-property-1.yaml: Language not supported
- core/src/test/resources/schemaDiff/required-property-2.yaml: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to cover issue #346. The issue is not related to the required handling, it is related to the AllOf handling.