Skip to content

#17876: Rust Server: Update dependency versions -- hyper 1.6, tokio 1.45, etc. #21332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

azriel-healthpoint
Copy link

Short version:

  1. This likely should've been done against the 8.0.x branch, but I began the branch off master, and I pulled as much time as I can to push it back upstream (sorry 🙇).
  2. This means if any changes need to be made, someone else has to pick it up from here -- I'm essentially leaving you with where I got to.
  3. I haven't actually tested this via generation -- just ported the code over after getting things to compile on a project.
  4. Biggest changes are hyper 0.14 to 1.6, and tokio 0.2 to 1.45.
  5. hyper's service_fn requires hyper::service::service::Service to return a Request<Incoming>. The previous version had a Service return another Service
  6. Swagger 7.0.0-rc1 is needed because that depends on hyper 1.x; Feature/174/implement clone for make allow all authenticator Metaswitch/swagger-rs#179 may be of interest.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro

@azriel-healthpoint azriel-healthpoint force-pushed the feature/17876/update-rust-server-dependency-versions branch from d6aa351 to 5fcecae Compare May 27, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant