PHP 8.0: RemovedFunctions: handle 21 removed/deprecated functions #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Deprecate enchant_broker_set_dict_path, enchant_broker_get_dict_path > enchant_dict_add_to_personal and enchant_dict_is_in_session Ref: https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/NEWS#L71 > - enchant_broker_set_dict_path and enchant_broker_get_dict_path > not available in libenchant < 1.5 nor in libenchant-2 > - enchant_dict_add_to_personal, use enchant_dict_add instead > - enchant_dict_is_in_session, use enchant_dict_is_added instead > - enchant_broker_free and enchant_broker_free_dict, unset the object instead Refs: * https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/UPGRADING#L662-L666 * php/php-src#5492 * php/php-src@66d42e9 * php/php-src#5577 * php/php-src@cd3e04d Includes unit tests.
…ebug() > oci_internal_debug() and its alias ociinternaldebug() have been removed. Refs: * https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/UPGRADING#L325 * php/php-src#5810 * php/php-src@11f4a5e Includes adjusted unit tests.
> The procedural API of Zip is deprecated. Use ZipArchive instead Refs: * https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/UPGRADING#L677 * php/php-src@f3b1f34 Includes unit tests.
> - The openssl_x509_free() function is deprecated and no longer has an effect, > instead the OpenSSLCertificate instance is automatically destroyed if it is no > longer referenced. > - The openssl_pkey_free() function is deprecated and no longer has an effect, > instead the OpenSSLAsymmetricKey instance is automatically destroyed if it is no > longer referenced. Refs: * https://github.com/php/php-src/blob/71bfa5344ab207072f4cd25745d7023096338385/UPGRADING#L384-L399 * php/php-src#5860 * php/php-src@9f44eca#diff-7748eb3bfdd3bf962553f6f9f2723c45 Includes unit tests.
> LibXML: > - libxml_disable_entity_loader() has been deprecated. As libxml 2.9.0 is now > required, external entity loading is guaranteed to be disabled by default, > and this function is no longer needed to protect against XXE attacks. Refs: * https://github.com/php/php-src/blob/71bfa5344ab207072f4cd25745d7023096338385/UPGRADING#L808-L811 * php/php-src#5867 * php/php-src@e0fa48f Includes unit tests.
jrfnl
added
enhancement
PR: quick merge
wimg
approved these changes
Aug 16, 2020
jrfnl
removed
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this PR line up with the commits in PHP Core to remove the functions.
Related to #809
PHP 8.0: RemovedFunctions - account for deprecated Enchant functions
Ref: https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/NEWS#L71
Refs:
Includes unit tests.
PHP 8.0: RemovedFunctions - handle removed support for oci_internal_debug()
Refs:
Includes adjusted unit tests.
PHP 8.0: RemovedFunctions - account for deprecated Zip functions
Refs:
Includes unit tests.
PHP 8.0: RemovedFunctions - account for deprecated OpenSSL functions
Refs:
Includes unit tests.
PHP 8.0: RemovedFunctions - account for deprecated libXML function
Refs:
Includes unit tests.