Skip to content

Simplify trait sealing and copy-edit the convert module. #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2022
Merged

Simplify trait sealing and copy-edit the convert module. #294

merged 1 commit into from
Mar 17, 2022

Conversation

adamreichold
Copy link
Member

No description provided.

davidhewitt
davidhewitt approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamreichold
Copy link
Member Author

Branched off the release-0.16 maintenance branch as this will technically be a breaking change due to changing how the public internal traits are sealed or actually sealing them in the case of NpyIndex and ToNpyDims as crate::convert::PrivateMarker was not actually private, even though it should not practically be breaking as no downstream crate was supposed to implement these.

@adamreichold adamreichold merged commit e933e27 into main Mar 17, 2022
@adamreichold adamreichold deleted the copy-edit-convert branch March 17, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamreichold @davidhewitt