Skip to content

Update docker and fairseq #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025
Merged

Update docker and fairseq #1116

merged 4 commits into from
Jun 2, 2025

Conversation

wannaphong
Copy link
Member

From #1049, I fixed the Dockerfile to use Python 3.12 and updated docker_requirements.txt. I was changing a few list requirements because fairseq doesn't support Python >= 3.11, so I used fairseq-fixed, and it worked!

Test: https://github.com/wannaphong/pythainlp-docker-cpu/actions/runs/15269221001

Dockerfile: https://github.com/wannaphong/pythainlp-docker-cpu/blob/main/Dockerfile

@wannaphong wannaphong linked an issue May 27, 2025 that may be closed by this pull request
@coveralls
Copy link

coveralls commented May 27, 2025

Coverage Status

coverage: 52.88% (-0.05%) from 52.931%
when pulling ad0d2ea on update-docker-fairseq
into c088c09 on dev.

@wannaphong
Copy link
Member Author

I added RUN python -m unittest tests.core and it passed!

https://github.com/wannaphong/pythainlp-docker-cpu/actions/runs/15269454827

@bact bact added the dependencies Pull requests that update a dependency file label May 27, 2025
Copy link

@wannaphong wannaphong merged commit 0c836ef into dev Jun 2, 2025
43 of 45 checks passed
@wannaphong wannaphong deleted the update-docker-fairseq branch June 2, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dockerfile
3 participants