This repository was archived by the owner on Apr 24, 2020. It is now read-only.
Numpy polynomial correction #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2019 11:08
faster, more pythonic and use techniques explained in the text
The np.poly1d() method takes the coefficients in decreasing powers so they need to be flipped (np.flip()) before making the call Improved the test case as this error wasn't detected when using identical coefficients. Moved the tested value to a variable rather than hard coded Made the code more pythonic using np.ones_like() rather than np.empty(len(coef))
added 2 commits
September 24, 2019 17:34
… to make it" This reverts commit a8c4795.
|
My apologies for the mixup. I have did a git revert on the 688 commit on the numpy correction branch. I hope this fixes the pb. |
|
Thanks @jez-w, nice work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.