Skip to content

Develop stream 2024-11-07 #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Nov 20, 2024
Merged

Develop stream 2024-11-07 #486

merged 42 commits into from
Nov 20, 2024

Conversation

NB4444
Copy link
Contributor

@NB4444 NB4444 commented Nov 7, 2024

This PR also includes commits from this PR which should be merged before. The new commits that are included add:

  • Workaround compiler issue for inclusive/exclusive scan with FixedVector items
  • CCCL/thrust 2.5.0 compatibility
  • Fallback implementation for thrust::copy_if
  • Add search_n, search, find_end and adjacent_find to hipstdpar
  • Update hipCUP tests and benchmarks default to c++17
  • Fixed c++17 tuple test

@NB4444 NB4444 force-pushed the develop-upstream-2024-11-07 branch from 64d84b9 to a0e0108 Compare November 7, 2024 10:28
@NB4444 NB4444 marked this pull request as ready for review November 7, 2024 11:52
@stanleytsang-amd stanleytsang-amd mentioned this pull request Nov 20, 2024
Merged
Beanavil and others added 22 commits November 20, 2024 07:10
@Beanavil @NB4444
Workaround compiler issue for inclusive/exclusive scan with FixedVect…
8a430ef 
…or items
@Beanavil @NB4444
Added missing explicit qualification of pow
1310156
@Beanavil @NB4444
Ensure that {cr}begin works with types that pull in namespace std via…
6c9e1da 
… ADL
@Beanavil @NB4444
Various and sundry fixes for Thrust's CPP backends.
ae5d545
@Beanavil @NB4444
Expose thrust's contiguous iterator unwrap helpers
c809820
@Beanavil @NB4444
Several improvements to zip_iterator/zip_function
9fa77a7
@Snektron @NB4444
Fix thrust::optional<T&>::emplace()
f344300 
Where optional<T> inherits optional<T>::construct via a series
of classes, optional<T&> does not. This means that
optional<T&>::emplace() was broken and called into a member function
that did not exist.

This replaces the functionality to make optional<T&>::emplace() change
the stored reference to the new one. Note that it does _not_ emplace
the referee, as this would lead to questionable behavior when the
optional holds nullopt.

This was revealed by a change in LLVM, see
llvm/llvm-project#90152 and
ROCm#404.
@Beanavil @NB4444
Fix issues that came up with building cuDF with main
fff9194
@Beanavil @NB4444
Bump version to 2.5.0
a043e52
@Beanavil @NB4444
Add test for CUDA backend to make sure that thrust::counting_iterator…
52b181b 
… is supported from cuda::std
@Beanavil @NB4444
Remove redundant thrust dialect conditional
15aa651
@Beanavil @NB4444
Move visibility attributes to cccl
46e4cf5
@Beanavil @NB4444
Fix logic for including libcudacxx headers
85f661c
@parbenc @NB4444
add find_first_of to HIPSTDPAR
91b5e9d
@parbenc @NB4444
fix memory free on error
ba8ed85
@parbenc @NB4444
fix review comments
8c01ac4
@parbenc @NB4444
fix rocprim::find_first_of usage
e9e1ae4
@parbenc @NB4444
fix copy_if to work with large data types
9a0a4bd
@parbenc @NB4444
fix tests
175874b
@parbenc @NB4444
fix copyright date
3660790
@parbenc @NB4444
add another operator== for large_data
10e9bde 
add large_data only to copy tests
@parbenc @NB4444
add casts to make code clearer
e5861e8
NB4444 and others added 20 commits November 20, 2024 07:11
@NB4444
Added search and find_end to hipstdpar
41f1c16
@NB4444
Fix compile warning
61b5969
@Beanavil @NB4444
Add missing CHANGELOG entry for CCCL 2.5.0 update
adccd88
@Beanavil @NB4444
Add rocPRIM's adjacent_find to hipstdpar
6fa1780
@Beanavil @NB4444
Consistently use thrust::equal_to as default operator
2ec8d67
@cenxuantian @NB4444
add change log
551c89d
@cenxuantian @NB4444
Add search_n support
881c24c
@cenxuantian @NB4444
fix windows build failed
5c6b6ce
@cenxuantian @NB4444
Add overload under std namespace
f07abfb
@cenxuantian @NB4444
add typename before
6ee5780
@cenxuantian @NB4444
add typename before
9a69c96
@cenxuantian @NB4444
Work in progress
09f43b7
@cenxuantian @NB4444
Work in progress
b7ed21f
@cenxuantian @MiloLurati @NB4444
Apply 1 suggestion(s) to 1 file(s)
75e4cae 
Co-authored-by: Milo Lurati <[email protected]>
@cenxuantian @NB4444
fix function name mistakes
604d8b8
@NB4444
Set c++ version to 17 and create warning
53b81eb
@NB4444
Fix no_discard warning c++17
8c4ee2b
@NB4444
Build for both c++ 14 and 17
a016a0f
@NB4444
Fix tuple test for c++17
449b0d3
@NB4444
Add new documentation for tuple.h
0a39100
@NB4444 NB4444 force-pushed the develop-upstream-2024-11-07 branch from a0e0108 to 0a39100 Compare November 20, 2024 07:14
@NB4444
Copy link
Contributor Author

NB4444 commented Nov 20, 2024

I rebased this PR. Looking at the commits this will need the PR in rocprim, ROCm/rocPRIM#631.

NguyenNhuDi
NguyenNhuDi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@NguyenNhuDi NguyenNhuDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all unit tests for this pr still passing on gfx908 and gfx1101.

stanleytsang-amd
stanleytsang-amd approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@stanleytsang-amd stanleytsang-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good for now (although the failures in the unspecified devops CI system are worrisome). I noticed the new changelog entry should be for 6.4. We can update that ourselves in a separate PR after merging this one in.

@stanleytsang-amd stanleytsang-amd merged commit d8ee6ee into ROCm:develop Nov 20, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleytsang-amd stanleytsang-amd stanleytsang-amd approved these changes

@NguyenNhuDi NguyenNhuDi NguyenNhuDi approved these changes

@umfranzw umfranzw Awaiting requested review from umfranzw umfranzw is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NB4444 @stanleytsang-amd @NguyenNhuDi @Beanavil @Snektron @parbenc @cenxuantian