Skip to content

Update Onnx Export #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

NaruseMioShirakana
Copy link
Contributor

Update Onnx Export

@RVC-Boss
Copy link
Owner

RVC-Boss commented Apr 3, 2025

@L-jasmine 感觉你俩的代码有冲突,有办法合一起吗,或者把torchscipt的部分拆出到别的py去?

@L-jasmine
Copy link
Contributor

@L-jasmine 感觉你俩的代码有冲突,有办法合一起吗,或者把torchscipt的部分拆出到别的py去?

@RVC-Boss 哪个文件有冲突?我这里好像看不到冲突。我明天仔细对一下,要提取到别的py 也可以

@RVC-Boss
Copy link
Owner

RVC-Boss commented Apr 4, 2025

@L-jasmine 感觉你俩的代码有冲突,有办法合一起吗,或者把torchscipt的部分拆出到别的py去?

@RVC-Boss 哪个文件有冲突?我这里好像看不到冲突。我明天仔细对一下,要提取到别的py 也可以

@L-jasmine https://github.com/RVC-Boss/GPT-SoVITS/pull/2258/files#diff-0717e9c822f278db602fcc4037bc1340671ebcc407ce41398f5b69a49a0092fb
models_onnx.py,我看有的函数接口变化了
就是你拿新代码跑跑看torchscipt还能正常跑吗

@L-jasmine
Copy link
Contributor

L-jasmine commented Apr 7, 2025

@RVC-Boss 确实有变化 v3 CFM 那里应该不兼容了 不过不要紧 我复制一份现在的 model_onnx 到 model_torchscript 吧。后面我再提一个新的pr,把 torchScript 的改成用 model_torchscript.
不过话又说回来,onnx的 export 是 trace 的,这个pr里面的 model_onnx 的 cfm 可能会因为 trace 的机制导致一些变量被 trace 成常量,希望作者是有详细测试过的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants