Skip to content

added array support #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2019
Merged

added array support #13

merged 4 commits into from
Sep 5, 2019

Conversation

DvirDukhan
Copy link
Contributor

added array support

client_test.go Outdated
graph.Query("MATCH (n) DELETE n")

a := NodeNew("Person", "a", nil)
b := NodeNew("Person", "b", nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not see where you use those 'a' and 'b' vars

Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small comment.

Copy link
Contributor

@jeffreylovitz jeffreylovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

client_test.go Outdated

res_a := arr[0].(*Node)
res_b := arr[1].(*Node)
if res_a.GetProperty("name") != "a" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a short comment explaining this logic.

@swilly22 swilly22 merged commit eb62d44 into master Sep 5, 2019
@swilly22 swilly22 deleted the array_support branch September 5, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants