Skip to content

Extended client with examples folder and godoc with 3 examples … #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2020

Conversation

filipecosta90
Copy link
Contributor

Extended the client with examples folder and godoc with 3 examples on how to connect to the RedisGraph Server. ( simplest way possible, with pool, and with SSL )
The examples (with exception to tls ) are part of the tests ( via the Output: ... directive ). Here is the aspect of it:
image
Regarding tls support it is also included as pluggable example given that it's more complex and users can get the example working on their system very quickly. ( we're making it have the same look and feel across all modules ). Regarding testing of the tls examples (lets wait a bit for the redisgraph:edge to be able to support it --matter of days ) given that the docker images requires openmp and other dependencies and hacking around it is more difficult than on other modules.
To test tls example locally:

redis-server --tls-port 6380 --port 6379 --tls-cert-file <path_to>/redis.crt --tls-key-file <path_to>/redis.key  --tls-ca-cert-file <path_to>/ca.crt   --loadmodule <path_to>/redisgraph.so

then on the go client:

$> TLS_CERT=<path_to>/redis.crt TLS_KEY=<path_to>/redis.key TLS_CACERT=/<path_to>/ca.crt REDISGRAPH_TEST_HOST=127.0.0.1:6380 make examples
go get -t -v ./...
 
Building the examples...
go build ./examples/redisgraph_tls_client/.
./redisgraph_tls_client --tls-cert-file <path_to>/redis.crt \
                                         --tls-key-file <path_to>/redis.key \
                                         --tls-ca-cert-file <path_to>/ca.crt \
                                         --host 127.0.0.1:6380
WorkPlace

…on how to connect to the RedisGraph Server. ( simplest way possible, with pool, and with SSL )
@filipecosta90
Copy link
Contributor Author

@swilly22 I believe all comments were addressed. Can you review again?

@filipecosta90 filipecosta90 requested a review from swilly22 May 13, 2020 18:12
@swilly22 swilly22 merged commit c82e342 into master May 13, 2020
@swilly22 swilly22 deleted the examples branch May 13, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants