Non uniform for everything! #177
Draft
+233
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
requested review from
eddyb,
LegNeato and
fornwall
as code owners
Firestar99
force-pushed
the
non-uniform
branch
3 times, most recently
from
d64dd36 to
ea25c7e
Compare
|
I wonder if we should land this behind an off-by-default flag? Or maybe that is more trouble than it is worth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the NonUniform declaration to pretty much everything, even if it's not required. I don't think this will have a huge performance impact, as Nvidia and Intel don't seem to care about this flag, their accesses are always non-uniform, and Amd's driver is really good at figuring out whether something is uniform / scalar across the workgroup / subgroup or not.
You will have to declare
SpirvBuilder::capability(Capability::ShaderNonUniform)for it to work though.Feel free to cherry-pick these commits if you do need non-uniform now and can't wait until rust-gpu has figured out a proper solution.