Skip to content

add missing LinearAlgebra methods on GPU #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

vpuri3
Copy link
Member

@vpuri3 vpuri3 commented Oct 24, 2023

fix #227
TODO

  • dot
  • adoint/transpose multiplication of vectors simply falls back on to dot (for both real and complex, so those methods aren't necessary).

@jonniedie LMK if you want me to add tests.

@vpuri3
Copy link
Member Author

vpuri3 commented Oct 25, 2023

@avik-pal, @ChrisRackauckas can any one of you approve the workflows?

@ChrisRackauckas
Copy link
Member

@jonniedie has to

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #226 (bcb9036) into main (df9bd66) will decrease coverage by 0.21%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   73.24%   73.03%   -0.21%     
==========================================
  Files          23       23              
  Lines         725      727       +2     
==========================================
  Hits          531      531              
- Misses        194      196       +2     
Files Coverage Δ
ext/ComponentArraysGPUArraysExt.jl 50.00% <0.00%> (-1.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonniedie
Copy link
Collaborator

LMK if you want me to add tests

If you could and bump the version, that'd be great, thanks!

@vpuri3
Copy link
Member Author

vpuri3 commented Oct 25, 2023

done

@jonniedie jonniedie merged commit d22a56c into SciML:main Oct 25, 2023
@vpuri3 vpuri3 deleted the patch-1 branch October 25, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add missing LinearAlgebra methods on GPU
4 participants