-
-
Notifications
You must be signed in to change notification settings - Fork 221
feat: cache start system and solver in HomotopyContinuation interface #3192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cache start system and solver in HomotopyContinuation interface #3192
Conversation
I realized polynomial checking doesn't take into account observed variables, so we don't report a nice error. |
@parameters n::Integer = 4 | ||
@mtkbuild sys = NonlinearSystem([x^n + x^2 - 1 ~ 0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not supporting integer parameter exponents is a pretty big limitation. It means that very common expressions in bio/pharma modeling, Hill expressions, would not be usable here (i.e. terms like x^n / (K + x^n)
where n
is an integer parameter). Is there no way to handle them? They should, ultimately, reduce down to polynomials once the denominators are removed and the integer exponent values are substituted in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. We can't cache the start system with parametric exponents. @ChrisRackauckas I guess we just have to do the caching optionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't the hill functions in this case use @constant
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also worth noting that pure HomotopyContinuation.jl doesn't allow parametric exponents either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parametric exponents are re-allowed with a warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks.
Extension test failures are BifurcationKit failing to precompile |
But this would be in extension tests. Just flip the order so we can see it pass. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.