Skip to content

Fix ImperativeAffect namespacing for arrays in non-root components #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025

Conversation

BenChung
Copy link
Contributor

@BenChung BenChung commented May 1, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

ImperativeAffect's renamespace doesn't properly handle ParentScope array arguments, instead munging them into a single symbol containing the string-ed array. This change explicitly handles this case of renamespacing.

Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests

@BenChung BenChung requested a review from ChrisRackauckas May 6, 2025 04:58
@ChrisRackauckas
Copy link
Member

Is the FMI failure related? Idon't think that was on master.

@BenChung
Copy link
Contributor Author

BenChung commented May 6, 2025

@ChrisRackauckas Looks like it, huh. My suspicion is that the FMI compilation is running into the array variable scoping problems that I'm poking at with this. I'll talk to Aayush and see if there's a better way to fix this

@BenChung BenChung requested a review from ChrisRackauckas May 6, 2025 22:05
@ChrisRackauckas ChrisRackauckas merged commit ebd3131 into SciML:master May 7, 2025
32 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants