-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add example for asserting with java on getting_started/using_selenium #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for asserting with java on getting_started/using_selenium #1672
Conversation
…enium/ Example for Asserting added for java language, by creating AssertionsTest.java file and adding relevant code lines reference in the markdown file.
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Description updated to latest commit (9f9d814)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Example for Setting up and Tearing down added for java language, by creating SetupAndTeardownTest.java file, and adding relevant code lines reference in the markdown file(s).
examples/java/src/test/java/dev/selenium/getting_started/SetupAndTeardownTest.java
Outdated
Show resolved
Hide resolved
Assertion and Setup/Teardown examples linked with existing UsingSeleniumTest.java, removed AssertionsTest.java and SetupAndTeardownTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also make changes to the Portuguese and Chinese translations?
examples/java/src/test/java/dev/selenium/getting_started/UsingSeleniumTest.java
Outdated
Show resolved
Hide resolved
examples/java/src/test/java/dev/selenium/getting_started/UsingSeleniumTest.java
Outdated
Show resolved
Hide resolved
examples/java/src/test/java/dev/selenium/getting_started/UsingSeleniumTest.java
Outdated
Show resolved
Hide resolved
examples/java/src/test/java/dev/selenium/getting_started/UsingSeleniumTest.java
Outdated
Show resolved
Hide resolved
examples/java/src/test/java/dev/selenium/getting_started/UsingSeleniumTest.java
Outdated
Show resolved
Hide resolved
examples/java/src/test/java/dev/selenium/getting_started/UsingSeleniumTest.java
Outdated
Show resolved
Hide resolved
1. BeforeAll and AfterAll functions removed. 2. Print statements removed. 3. driver.manage().window().maximize() removed. 4. Driver navigation and implicit wait code moved into test body. 5. Markdown changes done in all the 4 languages.
As asked, the following changes have been done -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @harshitBhardwaj97!
|
…#1672) * Add example for asserting with java on page getting_started/using_selenium/ Example for Asserting added for java language, by creating AssertionsTest.java file and adding relevant code lines reference in the markdown file. * Documentation updated for using_selenium.ja.md * Add example of Setting up and Tear down with java Example for Setting up and Tearing down added for java language, by creating SetupAndTeardownTest.java file, and adding relevant code lines reference in the markdown file(s). * Assertion and Setup/Teardown examples linked Assertion and Setup/Teardown examples linked with existing UsingSeleniumTest.java, removed AssertionsTest.java and SetupAndTeardownTest.java * Do the requested changes 1. BeforeAll and AfterAll functions removed. 2. Print statements removed. 3. driver.manage().window().maximize() removed. 4. Driver navigation and implicit wait code moved into test body. 5. Markdown changes done in all the 4 languages. [deploy site] cf913c3
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Example for Asserting added for java language, by creating AssertionsTest.java file and
adding relevant code lines reference in the markdown file.
Motivation and Context
Types of changes
Checklist
Type
enhancement, documentation
Description
AssertionsTest.java
demonstrating how to use assertions in Selenium tests with Java.Changes walkthrough
AssertionsTest.java
Add Java Selenium Assertions Example
examples/java/src/test/java/dev/selenium/getting_started/AssertionsTest.java
AssertionsTest
with a test methodassertionTest
demonstrating how to perform assertions in Seleniumtests.
element.
using_selenium.en.md
Update Selenium Getting Started Guide with Assertions Example
website_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md
AssertionsTest.java
.using_selenium.ja.md
Update Japanese Selenium Documentation with Assertions Example
website_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md
AssertionsTest.java
in the Japanese version ofthe documentation.