-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Start adding special features examples #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start adding special features examples #1711
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Description updated to latest commit (bbdc626)
|
PR Review 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aguspe !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @aguspe,
Can we just include code from L119-L122 Or L124?
Hi @harsha509 thank you so much for the question, I think the best is still L119-L124 because in the current implementation if people try just to use @driver.cast_sinks it will actually not work I made a question regarding this on the slack channel to see how much we needed to expand the example for the users, here is the message: https://seleniumhq.slack.com/archives/C0K0BK8MQ/p1715280896233389 |
L119-L124 looks fine to me... |
Perfect thank you so much @harsha509, let me know if there are other questions |
website_and_docs/content/documentation/webdriver/browsers/chrome.en.md
Outdated
Show resolved
Hide resolved
…into special_features_ruby_examples
User description
Description
Right now none of the example features under Chrome have examples for users to follow, this PR adds the casting example
Motivation and Context
The goal of this PR is to provide users with an overview of what special features they can use with Chrome
Types of changes
Checklist
PR Type
enhancement, documentation
Description
Changes walkthrough 📝
chrome_spec.rb
Add Ruby example for casting in Chrome
examples/ruby/spec/browsers/chrome_spec.rb
functionality in Chrome.
performs tab mirroring if devices are available.
chrome.en.md
Update English Chrome documentation with new Ruby example
website_and_docs/content/documentation/webdriver/browsers/chrome.en.md
example.
chrome.ja.md
Update Japanese Chrome documentation with new Ruby example
website_and_docs/content/documentation/webdriver/browsers/chrome.ja.md
example.
chrome.pt-br.md
Update Portuguese Chrome documentation with new Ruby example
website_and_docs/content/documentation/webdriver/browsers/chrome.pt-br.md
example.
chrome.zh-cn.md
Update Chinese Chrome documentation with new Ruby example
website_and_docs/content/documentation/webdriver/browsers/chrome.zh-cn.md
example.