Skip to content

Fixing English grammar #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fixing English grammar #1803

merged 2 commits into from
Jul 9, 2024

Conversation

Nisim761
Copy link
Contributor

@Nisim761 Nisim761 commented Jul 9, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Corrected a grammatical error in the "Assertions in Page Objects" section.
  • Added a newline at the end of the file to adhere to best practices.

Changes walkthrough 📝

Relevant files
Documentation
page_object_models.en.md
Fix grammatical error and add newline in documentation     

website_and_docs/content/documentation/test_practices/encouraged/page_object_models.en.md

  • Corrected a grammatical error in the text.
  • Added a newline at the end of the file.
  • +2/-2     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Jul 9, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 1562a95

    @CLAassistant
    Copy link

    CLAassistant commented Jul 9, 2024

    CLA assistant check
    All committers have signed the CLA.

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 1 labels Jul 9, 2024
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2024

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Readability
    Rephrase the sentence to improve readability and clarity

    To improve readability and clarity, consider rephrasing the sentence to avoid redundancy
    and make it more concise.

    website_and_docs/content/documentation/test_practices/encouraged/page_object_models.en.md [187]

    -part of your test and should always be within the test’s code, never in a page
    +part of your test and should always be within the test code, never in a page
     
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: The suggestion correctly identifies a minor redundancy in the text but the improvement is relatively minor and does not significantly enhance the clarity or readability of the document.

    5

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hi @Nisim761 ,

    Thank you for the PR.

    To maintain consistency across all language versions, could you please replicate the changes you made on the main page to the other translated pages which are in english (pt-br, zh-cn, ja)?

    Thanks,
    Sri

    @Nisim761
    Copy link
    Contributor Author

    Nisim761 commented Jul 9, 2024

    Hi @Nisim761 ,

    Thank you for the PR.

    To maintain consistency across all language versions, could you please replicate the changes you made on the main page to the other translated pages which are in English (pt-br, zh-cn, ja)?

    Thanks, Sri

    I am not really sure how. I only read the English version. I checked, couldn't find this error on other pages in English.

    @harsha509
    Copy link
    Member

    Hi @Nisim761 ,
    Thank you for the PR.
    To maintain consistency across all language versions, could you please replicate the changes you made on the main page to the other translated pages which are in English (pt-br, zh-cn, ja)?
    Thanks, Sri

    I am not really sure how. I only read the English version. I checked, couldn't find this error on other pages in English.

    No worries, i have updated other pages with commit fa62b40 referring to this PR!

    @harsha509 harsha509 merged commit 67cf1f4 into SeleniumHQ:trunk Jul 9, 2024
    3 checks passed
    @Nisim761
    Copy link
    Contributor Author

    Nisim761 commented Jul 9, 2024

    Hi @Nisim761 ,
    Thank you for the PR.
    To maintain consistency across all language versions, could you please replicate the changes you made on the main page to the other translated pages which are in English (pt-br, zh-cn, ja)?
    Thanks, Sri

    I am not really sure how. I only read the English version. I checked, couldn't find this error on other pages in English.

    No worries, i have updated other pages with commit fa62b40 referring to this PR!

    Thank you!

    selenium-ci added a commit that referenced this pull request Jul 9, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants