-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fixing English grammar #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing English grammar #1803
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Nisim761 ,
Thank you for the PR.
To maintain consistency across all language versions, could you please replicate the changes you made on the main page to the other translated pages which are in english (pt-br, zh-cn, ja)?
Thanks,
Sri
I am not really sure how. I only read the English version. I checked, couldn't find this error on other pages in English. |
No worries, i have updated other pages with commit fa62b40 referring to this PR! |
Thank you! |
Co-authored-by: Sri Harsha <[email protected]> 67cf1f4
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Documentation
Description
Changes walkthrough 📝
page_object_models.en.md
Fix grammatical error and add newline in documentation
website_and_docs/content/documentation/test_practices/encouraged/page_object_models.en.md