Skip to content

Delete: Removing duplicate browser navigation commands #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Delete: Removing duplicate browser navigation commands #233

merged 2 commits into from
Feb 17, 2020

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Feb 17, 2020

Description

All browser navigation commands are covered in browser Manipulation

We can remove the duplicate document from support packages

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harsha509, could you please have a look and resolve the merge conflict?

@hirata-k
Copy link

Thank you @harsha509, could you remove browser_navigation.ja.md, please ?

@harsha509
Copy link
Member Author

Thank you @harsha509, could you remove browser_navigation.ja.md, please ?

I am sure I have deleted the file, maybe the merge conflicts were due to new merges into master.

@harsha509 harsha509 requested a review from diemol February 17, 2020 09:12
@harsha509
Copy link
Member Author

Thanks @harsha509, could you please have a look and resolve the merge conflict?

Resolved the merge conflicts @diemol.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diemol diemol merged commit 369fd1e into SeleniumHQ:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants