Skip to content

German translation for project and tools #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2020
Merged

German translation for project and tools #235

merged 2 commits into from
Feb 18, 2020

Conversation

boris779
Copy link
Contributor

Description

German translation for project and tools

Motivation and Context

Missing german translation for that page

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • [] Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

harsha509
harsha509 requested changes Feb 18, 2020
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @boris779 ,

Thanks for the PR. There are a few minor changes. Can you please take a look

Regards,
Harsha

diemol
diemol approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @boris779, keep them coming!

@diemol diemol merged commit 6089f6a into SeleniumHQ:master Feb 18, 2020
@boris779 boris779 deleted the german_project_and_tools branch February 20, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha509 harsha509 harsha509 requested changes

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boris779 @diemol @harsha509