Skip to content

updating page_loading_strategy.ja.md #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

abhishek-malani-zz
Copy link

updating page loading strategy for japanese language

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

updating page loading strategy for japanese language
@CLAassistant
Copy link

CLAassistant commented Mar 22, 2020

CLA assistant check
All committers have signed the CLA.

harsha509 added a commit that referenced this pull request Mar 22, 2020
@harsha509
Copy link
Member

Hi @abhishek-malani ,

Thanks for the PR. I've merged one of the PR which contains your changes. Usually we do create a single PR for any type changes for all translated pages.

Providing multiple is fine, but it triggers the 2 builds for each PR to get merged which consumes lot of time. So referring to all your PRs done for translated pages i've made a single commit.

Hope you're fine with it.

Regards,
Harsha

@harsha509 harsha509 closed this Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants