Skip to content

Add Chinese translation of "gmail_email_and_facebook_logins" #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alaahong
Copy link
Member

Description

Add Chinese translation of "gmail_email_and_facebook_logins"

  • worst_practices/gmail_email_and_facebook_logins.zh-cn.md

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

- worst_practices/gmail_email_and_facebook_logins.zh-cn.md
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alaahong , I have suggested a change. Can you please look into it.

Thanks,
Harsha

符合[W3C conformant](//w3c.github.io/webdriver/webdriver-spec.html)
的WebDriver实现,
也会使用 `webdriver` 的属性对 `navigator` 对象进行注释,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
也会使用 `webdriver` 的属性对 `navigator` 对象进行注释,
也会使用 `WebDriver` 的属性对 `navigator` 对象进行注释,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked with other documents, just revised all webdriver as WebDriver

…se WebDriver spelling

- worst_practices/gmail_email_and_facebook_logins.zh-cn.md
- worst_practices/gmail_email_and_facebook_logins.de.md
- worst_practices/gmail_email_and_facebook_logins.en.md
- worst_practices/gmail_email_and_facebook_logins.es.md
- worst_practices/gmail_email_and_facebook_logins.fr.md
- worst_practices/gmail_email_and_facebook_logins.ja.md
- worst_practices/gmail_email_and_facebook_logins.ko.md
- worst_practices/gmail_email_and_facebook_logins.nl.md

Revise webdriver as WebDriver
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you @alaahong !

@harsha509 harsha509 merged commit 37bcb93 into SeleniumHQ:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants