failed to compile Arduino_core_STM32 V1.8.0 based projects. V1.7.0 works fine

[engrziarehman]

I have 4.3.1 sloeber installed, all other repositories are compiling fine, except Arduino_Core_STM32, its 1.8.0 version installed.
I have created empty arduino project and selected Bluepill as controller, then after compilation it is giving error in the end while 'starting combiner' appears.

D:/sloeber431/sloeber/arduinoPlugin/tools/make/make --no-print-directory main-build
'Starting combiner'
"D:\sloeber431\sloeber\arduinoPlugin\packages\STM32\tools\xpack-arm-none-eabi-gcc\9.2.1-1.1/bin/arm-none-eabi-gcc" -mcpu=cortex-m3 -mthumb -Os --specs=nano.specs -Wl,--defsym=LD_FLASH_OFFSET=0x2000 -Wl,--defsym=LD_MAX_SIZE=65536 -Wl,--defsym=LD_MAX_DATA_SIZE=20480 -Wl,--cref -Wl,--check-sections -Wl,--gc-sections -Wl,--entry=Reset_Handler -Wl,--unresolved-symbols=report-all -Wl,--warn-common "-TD:\sloeber431\sloeber\arduinoPlugin\packages\STM32\hardware\stm32\1.8.0\variants\PILL_F103XX/ldscript.ld" "-Wl,-Map,Z:/Arduino/EclipseWorkspace/ArduinoCoreSTM32_test/Release/ArduinoCoreSTM32_test.map" "-LD:\sloeber431\sloeber\arduinoPlugin\packages\STM32\tools\CMSIS\5.5.1/CMSIS/DSP/Lib/GCC/" -larm_cortexM3l_math -o "Z:/Arduino/EclipseWorkspace/ArduinoCoreSTM32_test/Release/ArduinoCoreSTM32_test.elf" "-LZ:/Arduino/EclipseWorkspace/ArduinoCoreSTM32_test/Release" -Wl,--start-group .\ArduinoCoreSTM32_test.cpp.o .\core\variant\PeripheralPins.c.o .\core\variant\variant.cpp.o Z:/Arduino/EclipseWorkspace/ArduinoCoreSTM32_test/Release/arduino.ar -lc -Wl,--end-group -lm -lgcc -lstdc++
d:/sloeber431/sloeber/arduinoplugin/packages/stm32/tools/xpack-arm-none-eabi-gcc/9.2.1-1.1/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld.exe: Z:/Arduino/EclipseWorkspace/ArduinoCoreSTM32_test/Release/arduino.ar(startup_stm32yyxx.S.o): in function LoopFillZerobss': makefile:90: recipe for target 'ArduinoCoreSTM32_test.elf' failed (.text.Reset_Handler+0x26): undefined reference to SystemInit'
makefile:69: recipe for target 'all' failed
d:/sloeber431/sloeber/arduinoplugin/packages/stm32/tools/xpack-arm-none-eabi-gcc/9.2.1-1.1/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld.exe: Z:/Arduino/EclipseWorkspace/ArduinoCoreSTM32_test/Release/arduino.ar(main.cpp.o): in function premain()': main.cpp:(.text.startup._Z7premainv+0x4): undefined reference to HAL_NVIC_SetPriorityGrouping'
d:/sloeber431/sloeber/arduinoplugin/packages/stm32/tools/xpack-arm-none-eabi-gcc/9.2.1-1.1/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld.exe: Z:/Arduino/EclipseWorkspace/ArduinoCoreSTM32_test/Release/arduino.ar(board.c.o): in function init': board.c:(.text.init+0x0): undefined reference to hw_config_init'
collect2.exe: error: ld returned 1 exit status
make[1]: *** [ArduinoCoreSTM32_test.elf] Error 1
make: *** [all] Error 2

[jantje]

I don't see a 1.8 version

[ethomas997]

I found that builds with stm32/1.8.0 will fail, whereas changing to stm32/1.7.0 will succeed. This is with building a simple 'Blink' sketch for a BluePill board.

[jantje]

Which json file do you use? I do not have 1.8

[ethomas997]

The current json from stm32duino has 1.8.0:
https://raw.githubusercontent.com/stm32duino/BoardManagerFiles/master/STM32/package_stm_index.json

[jantje]

indeed doesn't seem to work.
No clue why. Someone knowing the stm32 should take a look and see what is wrong.

[ethomas997]

It looks like the ArduinoIDE using stm32 is on v1.8.0 and is able successfully do builds. Seems like the problem is specific to Sloeber-Eclipse.

[fpistm]

Hi,
Issue has been reported on stm32duino forum:
https://www.stm32duino.com/viewtopic.php?f=18&t=173&p=1268#p1268

It seems Sloeber doesn't handle properly the prebuild recipe from the platform.txt.
https://github.com/stm32duino/Arduino_Core_STM32/blob/f1d475a7ce9a73464bcf41b57d22803af8bc371a/platform.txt#L117-L120

[jantje]

@fpistm
Thanks for the investigation. I see 2 problems with the hooks right now.
The first command fails due to a / \ problem. Strangely enough the command works fine from the command line. So workaround : run the command from the command line. This is only needed once (and after removal of the release folder.
The second is more confusing to me.
The platform.txt contains
recipe.hooks.prebuild.3.pattern.windows=cmd /c echo #include ^<SrcWrapper.h^> > "{build.src_wrapper.path}"
As we are on windows Sloeber should create the key value environment variable
A.RECIPE.HOOKS.PREBUILD.3.PATTERN=cmd /c echo #include ^<SrcWrapper.h^> > "{build.src_wrapper.path}"
But on my system it is
A.RECIPE.HOOKS.PREBUILD.3.PATTERN=cmd /c echo
If found that this is caused because sloeber considers everything after # as a comment where only lines starting with # should be seen as comment lines https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5-3rd-party-Hardware-specification

This should be 2 relatively easy fixes.

[jantje]

the # comment problem only existed in non-boards related files like platform.txt.
The other fix is pretty low-level so I'm running the CreateAndCompileDefaultInoOnAllBoardsTest before releasing.

[fpistm]

welcome @jantje
I know how it is hard to maintain such project so when we can help 😉