Credit Card Validation Support #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Card validation
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 72.14% 73.56% +1.41%
==========================================
Files 27 30 +3
Lines 298 435 +137
==========================================
+ Hits 215 320 +105
- Misses 83 115 +32
Continue to review full report at Codecov.
|
Card validation fully complete
removed comment line
fixed month not validating past November
added checks for blank card expiry date causing crash
fixed endIndex error in expiry date validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new changes and inclusion of the CardParser Library, SwiftValidator is now able to check credit/debit card numbers for validity using their prefixes, length, and the LUHN algorithm. Verve card from Interswitch Nigeria has also been added to the list of cards it can verify. cool huh?