Skip to content

added automated doctest to decimal_to_hexadecimal.py in conversions #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2019
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 42 additions & 14 deletions conversions/decimal_to_hexadecimal.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,51 @@
}

def decimal_to_hexadecimal(decimal):
""" take decimal value, return hexadecimal representation as str """
"""
take integer decimal value, return hexadecimal representation as str beginning with 0x
>>> decimal_to_hexadecimal(5)
'0x5'
>>> decimal_to_hexadecimal(15)
'0xf'
>>> decimal_to_hexadecimal(37)
'0x25'
>>> decimal_to_hexadecimal(255)
'0xff'
>>> decimal_to_hexadecimal(4096)
'0x1000'
>>> decimal_to_hexadecimal(999098)
'0xf3eba'
>>> # negatives work too
>>> decimal_to_hexadecimal(-256)
'0x-100'
Copy link
Member

@cclauss cclauss Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test:

>>> decimal_to_hexadecimal(-256) == hex(-256)
True

https://docs.python.org/3/library/functions.html#hex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. This also made me realize that I was supposed to put '-' before '0x', which I fixed

>>> # floats are acceptable if equivalent to an int
>>> decimal_to_hexadecimal(17.0)
'0x11'
>>> # other floats will error
>>> decimal_to_hexadecimal(16.16) # doctest: +ELLIPSIS
Traceback (most recent call last):
...
AssertionError
>>> # strings will error as well
>>> decimal_to_hexadecimal('0xfffff') # doctest: +ELLIPSIS
Traceback (most recent call last):
...
AssertionError
"""
assert type(decimal) in (int, float) and decimal == int(decimal)
hexadecimal = ''
negative = False
if decimal < 0:
negative = True
decimal *= -1
while decimal > 0:
remainder = decimal % 16
decimal -= remainder
decimal, remainder = divmod(decimal, 16)
hexadecimal = values[remainder] + hexadecimal
decimal /= 16
if negative:
hexadecimal = '-' + hexadecimal
hexadecimal = '0x' + hexadecimal
return hexadecimal

def main():
""" print test cases """
print("5 in hexadecimal is", decimal_to_hexadecimal(5))
print("15 in hexadecimal is", decimal_to_hexadecimal(15))
print("37 in hexadecimal is", decimal_to_hexadecimal(37))
print("255 in hexadecimal is", decimal_to_hexadecimal(255))
print("4096 in hexadecimal is", decimal_to_hexadecimal(4096))
print("999098 in hexadecimal is", decimal_to_hexadecimal(999098))

if __name__ == '__main__':
main()
import doctest
doctest.testmod()