Added determinate function #1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
requested changes
Oct 24, 2019
cclauss
reviewed
Oct 24, 2019
cclauss
reviewed
Oct 24, 2019
| """ | ||
| A = Matrix([[1, 1, 4, 5], [3, 3, 3, 2], [5, 1, 9, 0], [9, 7, 7, 9]], 4, 4) | ||
| self.assertEqual(-376, A.determinate()) | ||
|
|
There was a problem hiding this comment.
Please add the following function to the bottom of this file just above line 160.
def force_test() -> None:
"""
This will ensure that pytest runs the unit tests above.
>>> unittest.main()
"""
passThere was a problem hiding this comment.
We can see that our tests are not being run:
https://travis-ci.com/TheAlgorithms/Python/builds/133339192#L386
|
Awesome. Sorry for the hiccups |
|
No problems. |
|
Please give some thought to #1124 (comment) |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added determinate function * Changed determinate function name * Changed instance of .det() to .determinate() * Added force_test() function * Update tests.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This is my first pull request so just let me know if there is anything else I should do. I thought the linear algebra class was missing a pretty important aspect of real valued matrices so thought it should be included.
It uses Laplace expansion to find the determinate recursively. It a pretty slow algorithm but it does the trick.