Skip to content

Fixes in methods and tests in Linear Algebra #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 24, 2019
Merged

Fixes in methods and tests in Linear Algebra #1432

merged 6 commits into from
Oct 24, 2019

Conversation

codecalec
Copy link
Contributor

Fixed issues with methods and tests
All tests seem to run fine now

@cclauss
Copy link
Member

cclauss commented Oct 24, 2019

Please also git mv linear_algebra/src/tests.py linear_algebra/src/test_linear_algebra.py to replicate the change in #1124 and then we can just close #1124 in favor of this PR. Awesome work!

@codecalec
Copy link
Contributor Author

Done

@cclauss
Copy link
Member

cclauss commented Oct 24, 2019

https://travis-ci.com/TheAlgorithms/Python/builds/133354390#L387 Awesome! Just one more change please. Let's remove that force_test() function that we created as it is no longer useful.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here! Thanks for fixing up our tests.

@cclauss cclauss merged commit ec85cc8 into TheAlgorithms:master Oct 24, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Fixes in methods and tests

* Renamed tests.py to test_linear_algebra.py

* removed force_test()

* Delete test_linear_algebra.py

* Format code with psf/black

* Rename tests.py to test_linear_algebra.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants