Skip to content

number_of_a_digit_with_list_of_digits #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

number_of_a_digit_with_list_of_digits #1977

wants to merge 1 commit into from

Conversation

Ankuraxz
Copy link

@Ankuraxz Ankuraxz commented May 13, 2020

PR #1975 #1976

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Ankuraxz
Copy link
Author

@cclauss

@cclauss
Copy link
Member

cclauss commented May 13, 2020

The input() call at global scope causes our automated tests to fail so it will need to be indented under https://docs.python.org/3/library/__main__.html

https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md#what-is-an-algorithm
An Algorithm is one or more functions (or classes) that:

  • take one or more inputs,
  • perform some internal calculations or data manipulations,
  • return one or more outputs,
  • have minimal side effects (Ex. print(), plot(), read(), write()).

@cclauss cclauss added the tests are failing Do not merge until tests pass label May 17, 2020
@cclauss
Copy link
Member

cclauss commented May 17, 2020

https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md

Please make your algorithm a function to make it easy for readers to put it into larger programs.

@stale
Copy link

stale bot commented Jun 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jun 16, 2020
@stale
Copy link

stale bot commented Jun 23, 2020

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

@stale stale bot closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used to mark an issue or pull request stale. tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants