Skip to content

Added file aliquot_sum.py #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 15, 2020
Merged

Added file aliquot_sum.py #1985

merged 10 commits into from
May 15, 2020

Conversation

ken437
Copy link
Contributor

@ken437 ken437 commented May 15, 2020

Describe your change:

I added a new algorithm in the maths directory that finds the aliquot sum of a number.
Algorithm explanation: https://en.wikipedia.org/wiki/Aliquot_sum

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [N/A] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss requested changes May 15, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

cclauss
cclauss approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Nice contribution. Thanks for doing this.

@cclauss cclauss merged commit a29a2a3 into TheAlgorithms:master May 15, 2020
@ken437
Copy link
Contributor Author

ken437 commented May 15, 2020

Well done! Nice contribution. Thanks for doing this.

You're welcome!

@ken437 ken437 deleted the aliquot_sum branch May 15, 2020 06:25
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@ken437 @cclauss @stokhos
Added file aliquot_sum.py (TheAlgorithms#1985)
77efc48 
* Added file aliquot_sum.py containing a function to find theo

* Added parameter type info to aliquot_sum.py

* Update maths/aliquot_sum.py

Co-authored-by: Christian Clauss <[email protected]>

* Update maths/aliquot_sum.py

Co-authored-by: Christian Clauss <[email protected]>

* Updated code to raise ValueErrors if input is bad

* Fixed logical operators

* Removed unnecessary import

* Updated aliquot_sum.py

* fixed formatting

* fixed documentation

Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ken437 @cclauss