Skip to content

Create hexadecimal_to_decimal #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 4, 2020
Merged

Create hexadecimal_to_decimal #2393

merged 16 commits into from
Sep 4, 2020

Conversation

mohammadreza490
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

ruppysuppy
ruppysuppy suggested changes Sep 4, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 4, 2020
View reviewed changes
conversions/hexadecimal_to_decimal Outdated
"E": 14,
"F": 15,
}
hex_string = hex_string.strip()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hex_string = hex_string.strip()
hex_string = hex_string.strip().lower()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do this once on the entire str instead of doing it on each character.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not mark this resolved if you have converted the entire string instead of converting it a character at a time.

cclauss
cclauss reviewed Sep 4, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 4, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 4, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 4, 2020
View reviewed changes
mohammadreza490 and others added 3 commits September 4, 2020 13:29
@mohammadreza490 @cclauss
Update conversions/hexadecimal_to_decimal
ee8edad 
Co-authored-by: Christian Clauss <[email protected]>
@mohammadreza490
Update hexadecimal_to_decimal
1889cc7 
Added negative hexadecimal conversion to decimal number
@mohammadreza490
Update hexadecimal_to_decimal
cd6eac3
cclauss
cclauss reviewed Sep 4, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 4, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 4, 2020
View reviewed changes
cclauss
cclauss approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reordered a few commands so that we do not create variables before we are sure that we will need them.

Reordered the tests so we show how it works before we show how it crashes.

@cclauss cclauss merged commit 1385e47 into TheAlgorithms:master Sep 4, 2020
@mohammadreza490
Copy link
Contributor Author

Thanks 🙏🏼

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@mohammadreza490 @ruppysuppy
@cclauss @stokhos
Create hexadecimal_to_decimal (TheAlgorithms#2393)
58fb9d3 
* Create hexadecimal_to_decimal

* Update conversions/hexadecimal_to_decimal

Co-authored-by: Tapajyoti Bose <[email protected]>

* Update conversions/hexadecimal_to_decimal

Co-authored-by: Tapajyoti Bose <[email protected]>

* Update conversions/hexadecimal_to_decimal

Co-authored-by: Christian Clauss <[email protected]>

* Update hexadecimal_to_decimal

* Update hexadecimal_to_decimal

* Update hexadecimal_to_decimal

* Update hexadecimal_to_decimal

* Update hexadecimal_to_decimal

* Update conversions/hexadecimal_to_decimal

Co-authored-by: Christian Clauss <[email protected]>

* Update hexadecimal_to_decimal

Added negative hexadecimal conversion to decimal number

* Update hexadecimal_to_decimal

* Update conversions/hexadecimal_to_decimal

Co-authored-by: Christian Clauss <[email protected]>

* Update conversions/hexadecimal_to_decimal

Co-authored-by: Christian Clauss <[email protected]>

* Update hexadecimal_to_decimal

* Update hexadecimal_to_decimal

Co-authored-by: Tapajyoti Bose <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy ruppysuppy requested changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadreza490 @cclauss @ruppysuppy