Electric power #3976
Merged
Electric power #3976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cclauss hello, sir please debug it and give me some tips and instructions, some lines in code are longer then 79 so what should i need to do???? |
ghost
added
tests are failing
|
Maximum line length is 88 characters. |
cclauss
reviewed
Nov 27, 2020
cclauss
reviewed
Nov 27, 2020
cclauss
reviewed
Nov 27, 2020
electronics/electric_power.py
Outdated
| result = (float(voltage * current)) | ||
| if result < 0: | ||
| result = result * -1 | ||
| return {'power': result} |
There was a problem hiding this comment.
Please use the builtin function abs()
https://docs.python.org/3/library/functions.html#abs
ghost
added
awaiting reviews
|
@cclauss all done sir. |
cclauss
requested changes
Nov 28, 2020
electronics/electric_power.py
Outdated
| >>> electric_power(voltage=2, current=2, power=0) | ||
| {'power': 4.0} | ||
| >>> electric_power(voltage=-2, current=3, power=0) | ||
| {'power': 6.0} |
There was a problem hiding this comment.
Need to test:
- No zeros
- Two zeros
- Negative numbers for power
- Floating-point numbers
Suggested change
| {'power': 6.0} | |
| >>> electric_power(voltage=-2, current=3, power=0).name | |
| 'power' | |
| >>> electric_power(voltage=-2, current=3, power=0).value | |
| 6.0 |
There was a problem hiding this comment.
Okay, should i also do this on ohms_law as well??
There was a problem hiding this comment.
Let's get this PR landed before you modify Ohm's law...
Coincidentally, @rhettinger (who wrote the namedtuple) just tweeted about Ohm's law...
https://twitter.com/raymondh/status/1331850115674345473
| @@ -0,0 +1,33 @@ | |||
| # https://en.m.wikipedia.org/wiki/Electric_power | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| from collections import namedtuple | |
| result = namedtuple("result", "name value") | |
electronics/electric_power.py
Outdated
| fundamental value of electrical system. | ||
| examples are below: | ||
| >>> electric_power(voltage=0, current=2, power=5) | ||
| {'voltage': 2.5} |
There was a problem hiding this comment.
Suggested change
| {'voltage': 2.5} | |
| result(name='voltage', value=2.5) |
electronics/electric_power.py
Outdated
| "Power cannot be negative in any electrical/electronics system" | ||
| ) | ||
| elif voltage == 0: | ||
| return {"voltage": power / current} |
There was a problem hiding this comment.
Suggested change
| return {"voltage": power / current} | |
| return result("voltage", power / current) |
ghost
added
awaiting changes
ghost
added
awaiting reviews
|
@cclauss sir run this code and you will see that with floating point values it will give you very long decimal value output, so my question is how to wrapped it, to only for 3 values after decimal point |
ghost
added
tests are failing
|
@cclauss I figured out, now all done??? |
ghost
added
awaiting reviews
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Used code from ohms_law algorithm, but now for power calculation
Checklist:
Fixes: #{$ISSUE_NO}.