Skip to content

Add Pollard's Rho algorithm for integer factorization #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add Pollard's Rho algorithm for integer factorization #5598

merged 1 commit into from
Oct 28, 2021

Conversation

llamasoft
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@llamasoft llamasoft requested a review from Kush1101 as a code owner October 25, 2021 17:07
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 25, 2021
@llamasoft
Copy link
Contributor Author

@cclauss is it possible to request an additional reviewer?
It appears that Kush1101 hasn't done any reviews in almost a year.

Also, apologies for pinging you directly but I saw that you were active recently. 😰

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 28, 2021
@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 28, 2021
@cclauss cclauss merged commit 5c8a6c8 into TheAlgorithms:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llamasoft @cclauss