Skip to content

Support rescript v11 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Support rescript v11 #16

merged 3 commits into from
Jul 4, 2023

Conversation

DZakh
Copy link
Contributor

@DZakh DZakh commented Jul 3, 2023

  • Get rid of dependency on Node module

@DZakh
Copy link
Contributor Author

DZakh commented Jul 3, 2023

Solves #15

@TheSpyder TheSpyder linked an issue Jul 3, 2023 that may be closed by this pull request
@TheSpyder
Copy link
Owner

I appreciate you kickstarting this!

Long term I probably need to think about supporting uncurried mode, which looks like it will come alongside a switch to optional record fields for configuration objects, but we'll see what I have time for in the major version change.

The tests didn't compile (reminding me that I need to add CI), the easiest fix was upgrading to rescript-zora v4 which now uses async/await instead of the new promise bindings. Turned out to be fairly simple once I got the hang of it.

Thanks for enabling maintainer edits, I've just pushed that up - if you're ok with those changes I'll merge it and probably do a beta release on a new major version number.

@DZakh
Copy link
Contributor Author

DZakh commented Jul 3, 2023

Looks good!

@DZakh
Copy link
Contributor Author

DZakh commented Jul 3, 2023

I've copied the github action from my packages. It should work for now

@TheSpyder
Copy link
Owner

Ah nice, I was wondering which action to use for yarn. I'll merge it and see how we go.

@TheSpyder TheSpyder merged commit 8001e79 into TheSpyder:main Jul 4, 2023
@DZakh
Copy link
Contributor Author

DZakh commented Jul 4, 2023

Ah, I've fucked up, haven't noticed that it's the pnpm action. I'll do a PR with a fix

@TheSpyder
Copy link
Owner

I was looking into that after I merged it but then something came up 😆

PR would be appreciated, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This code seems not to work with rescript 11.beta.2 and 3
2 participants