Hide server info and add security headers #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimsihk
changed the title
|
I would recommend everyone to apply all these headers, but I'm afraid they can break some webapps. Removing the server info is good practice and can't do any harm. If you can remove the |
|
Thanks for your thought, branch updated |
|
Thank you for your contribution @jimsihk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINX and PHP-FPM versions are currently exposed in HTTP headers which are considered not secure enough as exposed OS info. Also added HTTP response headers for higher security.
References:
https://kubernetes.github.io/ingress-nginx/deploy/hardening-guide/
https://www.upguard.com/blog/how-to-build-a-tough-nginx-server-in-15-steps
https://beaglesecurity.com/blog/article/nginx-server-security.html
https://stackoverflow.com/questions/962230/hide-x-powered-by-nginx