This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Formal overview minor fixes #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k contexts. Switching to "S ⊢ ..." notation for premises of typing rules for administrative instructions, to match the spec document. Readability: Changing quotes to number indices, and removing unnecessary explicit exponent variables. Suggesting prose for the new constructs in block contexts, connoting the new structured administrative instructions with control frame opcodes.
This commit will be soon moved to a PR with the minor (non-delegate specific) changes. Co-authored-by: Heejin Ahn <[email protected]>
|
I guess you can rebase #205 onto this after this lands. |
rossberg
reviewed
May 10, 2022
https://github.com/WebAssembly/exception-handling/pull/208/files#r868964603 by @rossberg > Oh, I think this rule needs to look up the arity of a, in order to know > how many values to keep, because T may contain an arbitrary prefix of > additional values that makes the decomposition ambiguous otherwise.
Ok! Just addressed @rossberg's review comment. I ran out of time now, will merge this tomorrow, then rebase #205, and continue addressing the review comments on delegate there. |
rossberg
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR with the commit containing the minor (not delegate specific) fixes from PR #205 as per @aheejin 's request in the beginning of this comment.