Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Miscellaneous fixes to formal overview document. #231

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

ioannad
Copy link
Collaborator

@ioannad ioannad commented Sep 9, 2022

In particular:

  • In previous reviews we dropped the kind property of labels, and went for labels of the form catch^? [t*] after all.
  • Changed some ^n to * where appropriate.
  • Removed occurrences of "we ..." formulations.

In particular:
- We dropped `kind` property of labels, and went for labels of the form `catch^? [t*]` after all.
- Changed some `^n` to `*` where appropriate.
- Removed occurrences of "we ..." formulations.
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we use n and when do we use *? I might have asked this before but I'm still confused.

And while this LGTM, I don't think we need to be very strict about styles in this markdown doc :)

@ioannad
Copy link
Collaborator Author

ioannad commented Sep 12, 2022

@aheejin

When do we use n and when do we use *? I might have asked this before but I'm still confused.

AFAIU we use n when it's relevant to other parts of the rule, meaning that n appears in two or more unrelated operations of the rule. For example, if the rule has a val^n and a label_n{}. (Can't think of another example atm, I hope this clarifies this a bit!)

@ioannad ioannad merged commit 2d732e6 into WebAssembly:main Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants