This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Few style fixes #232
Merged
Few style fixes #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aheejin
commented
Sep 12, 2022
aheejin
commented
- Change 'We denote X = Y' to 'Let A be Y' (suggested in Update formal spec to (partially) implement the 3rd EH proposal #180 (comment))
- Remove uses of 'we' pronouns (suggested in Update formal spec to (partially) implement the 3rd EH proposal #180 (comment))
- Change 'We denote X = Y' to 'Let A be Y' (suggested in WebAssembly#180 (comment)) - Remove uses of 'we' pronouns (suggested in WebAssembly#180 (comment))
aheejin
commented
Sep 12, 2022
rossberg
approved these changes
Sep 16, 2022
Co-authored-by: Andreas Rossberg <[email protected]> Co-authored-by: Ioanna M Dimitriou H <[email protected]>
|
Should I merge this @aheejin or would you rather do the merge? |
|
I was waiting for #219 to land because the two have merge conflicts, but I guess I can land first, if you fix the conflicts 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.