Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Addressing additional review comments to #227 #240

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

ioannad
Copy link
Collaborator

@ioannad ioannad commented Oct 21, 2022

that were made after that PR was merged.
In particular the following three comments are addressed,
about the prose to the "Exiting a catch clause |CAUGHTADM|".

that were made after that PR was merged.
In particular the following three comments are addressed.

- WebAssembly#227 (comment)
- WebAssembly#227 (comment)
- WebAssembly#227 (comment)
@@ -3052,18 +3052,18 @@ Throwing an exception with :ref:`tag address <syntax-tagaddr>` :math:`a`

.. _exec-caughtadm:

Exiting a |CAUGHTadm|
.....................
Exiting a catch clause |CAUGHTadm|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the |CAUGHTadm| here, since we do not use similar keywords elsewhere

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


When the |END| of a |CAUGHTadm|, is reached without a jump, exception, or trap, then the following steps are performed.
When the |END| of a catch clause |CAUGHTadm| is reached without a jump, exception, or trap, then the following steps are performed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


1. Let :math:`\val^\ast` be the values on the top of the stack.

2. Pop the values :math:`\val^\ast` from the stack.

3. Assert: due to :ref:`validation <valid-instr-seq>`, an administrative instruction :math:`\CAUGHTadm\{a~\val_0^\ast\}` is now on the top of the stack.

4. Pop the |CAUGHTadm| from the stack.
4. Pop the catch clause |CAUGHTadm| from the stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say: Pop the caught exception from the stack.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


When the |END| of a |CAUGHTadm|, is reached without a jump, exception, or trap, then the following steps are performed.
When the |END| of a catch clause |CAUGHTadm| is reached without a jump, exception, or trap, then the following steps are performed.

1. Let :math:`\val^\ast` be the values on the top of the stack.

2. Pop the values :math:`\val^\ast` from the stack.

3. Assert: due to :ref:`validation <valid-instr-seq>`, an administrative instruction :math:`\CAUGHTadm\{a~\val_0^\ast\}` is now on the top of the stack.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say here:

3. Assert: due to :ref:`validation <valid-instr-seq>`, a caught exception :math:`\{a~\val_0^\ast\}` is now on the top of the stack.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

by also rephrasing "|CAUGHTadm| instruction" to "catch clause".
@ioannad ioannad merged commit 5dd5d2e into WebAssembly:main Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants