-
Notifications
You must be signed in to change notification settings - Fork 36
Addressing additional review comments to #227 #240
Addressing additional review comments to #227 #240
Conversation
that were made after that PR was merged. In particular the following three comments are addressed. - WebAssembly#227 (comment) - WebAssembly#227 (comment) - WebAssembly#227 (comment)
document/core/exec/instructions.rst
Outdated
@@ -3052,18 +3052,18 @@ Throwing an exception with :ref:`tag address <syntax-tagaddr>` :math:`a` | |||
|
|||
.. _exec-caughtadm: | |||
|
|||
Exiting a |CAUGHTadm| | |||
..................... | |||
Exiting a catch clause |CAUGHTadm| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the |CAUGHTadm|
here, since we do not use similar keywords elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
document/core/exec/instructions.rst
Outdated
|
||
When the |END| of a |CAUGHTadm|, is reached without a jump, exception, or trap, then the following steps are performed. | ||
When the |END| of a catch clause |CAUGHTadm| is reached without a jump, exception, or trap, then the following steps are performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
document/core/exec/instructions.rst
Outdated
|
||
1. Let :math:`\val^\ast` be the values on the top of the stack. | ||
|
||
2. Pop the values :math:`\val^\ast` from the stack. | ||
|
||
3. Assert: due to :ref:`validation <valid-instr-seq>`, an administrative instruction :math:`\CAUGHTadm\{a~\val_0^\ast\}` is now on the top of the stack. | ||
|
||
4. Pop the |CAUGHTadm| from the stack. | ||
4. Pop the catch clause |CAUGHTadm| from the stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's say: Pop the caught exception from the stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
document/core/exec/instructions.rst
Outdated
|
||
When the |END| of a |CAUGHTadm|, is reached without a jump, exception, or trap, then the following steps are performed. | ||
When the |END| of a catch clause |CAUGHTadm| is reached without a jump, exception, or trap, then the following steps are performed. | ||
|
||
1. Let :math:`\val^\ast` be the values on the top of the stack. | ||
|
||
2. Pop the values :math:`\val^\ast` from the stack. | ||
|
||
3. Assert: due to :ref:`validation <valid-instr-seq>`, an administrative instruction :math:`\CAUGHTadm\{a~\val_0^\ast\}` is now on the top of the stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's say here:
3. Assert: due to :ref:`validation <valid-instr-seq>`, a caught exception :math:`\{a~\val_0^\ast\}` is now on the top of the stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
by also rephrasing "|CAUGHTadm| instruction" to "catch clause".
that were made after that PR was merged.
In particular the following three comments are addressed,
about the prose to the "Exiting a catch clause |CAUGHTADM|".