This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Addressing additional review comments to #227 #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that were made after that PR was merged. In particular the following three comments are addressed. - WebAssembly#227 (comment) - WebAssembly#227 (comment) - WebAssembly#227 (comment)
rossberg
reviewed
Nov 15, 2022
document/core/exec/instructions.rst
Outdated
| @@ -3052,18 +3052,18 @@ Throwing an exception with :ref:`tag address <syntax-tagaddr>` :math:`a` | |||
|
|
|||
| .. _exec-caughtadm: | |||
|
|
|||
| Exiting a |CAUGHTadm| | |||
| ..................... | |||
| Exiting a catch clause |CAUGHTadm| | |||
There was a problem hiding this comment.
Let's remove the |CAUGHTadm| here, since we do not use similar keywords elsewhere
document/core/exec/instructions.rst
Outdated
|
|
||
| When the |END| of a |CAUGHTadm|, is reached without a jump, exception, or trap, then the following steps are performed. | ||
| When the |END| of a catch clause |CAUGHTadm| is reached without a jump, exception, or trap, then the following steps are performed. |
document/core/exec/instructions.rst
Outdated
|
|
||
| 1. Let :math:`\val^\ast` be the values on the top of the stack. | ||
|
|
||
| 2. Pop the values :math:`\val^\ast` from the stack. | ||
|
|
||
| 3. Assert: due to :ref:`validation <valid-instr-seq>`, an administrative instruction :math:`\CAUGHTadm\{a~\val_0^\ast\}` is now on the top of the stack. | ||
|
|
||
| 4. Pop the |CAUGHTadm| from the stack. | ||
| 4. Pop the catch clause |CAUGHTadm| from the stack. |
There was a problem hiding this comment.
Let's say: Pop the caught exception from the stack.
document/core/exec/instructions.rst
Outdated
|
|
||
| When the |END| of a |CAUGHTadm|, is reached without a jump, exception, or trap, then the following steps are performed. | ||
| When the |END| of a catch clause |CAUGHTadm| is reached without a jump, exception, or trap, then the following steps are performed. | ||
|
|
||
| 1. Let :math:`\val^\ast` be the values on the top of the stack. | ||
|
|
||
| 2. Pop the values :math:`\val^\ast` from the stack. | ||
|
|
||
| 3. Assert: due to :ref:`validation <valid-instr-seq>`, an administrative instruction :math:`\CAUGHTadm\{a~\val_0^\ast\}` is now on the top of the stack. |
There was a problem hiding this comment.
Let's say here:
3. Assert: due to :ref:`validation <valid-instr-seq>`, a caught exception :math:`\{a~\val_0^\ast\}` is now on the top of the stack.
by also rephrasing "|CAUGHTadm| instruction" to "catch clause".
rossberg
approved these changes
Nov 22, 2022
aheejin
approved these changes
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that were made after that PR was merged.
In particular the following three comments are addressed,
about the prose to the "Exiting a catch clause |CAUGHTADM|".