This repository was archived by the owner on Apr 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Clarify descriptions of control flow operators #340
Merged
aheejin
merged 1 commit into
WebAssembly:main
from
Liedtke:clarify_control_flow_operators
Nov 21, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -703,9 +703,9 @@ throws, and rethrows as follows: | |
| `try` | `0x06` | sig : `blocktype` | begins a block which can handle thrown exceptions | | ||
| `catch` | `0x07` | index : `varint32` | begins the catch block of the try block | | ||
| `catch_all` | `0x19` | | begins the catch_all block of the try block | | ||
| `delegate` | `0x18` | relative_depth : `varuint32` | begins the delegate block of the try block | | ||
| `throw` | `0x08` | index : `varint32` | Creates an exception defined by the tag and then throws it | | ||
| `rethrow` | `0x09` | relative_depth : `varuint32` | Pops the `exnref` on top of the stack and throws it | | ||
| `delegate` | `0x18` | relative_depth : `varuint32` | ends the current try block and delegates any exceptions to the block at `relative_depth` | | ||
| `throw` | `0x08` | index : `varint32` | creates an exception defined by the tag and then throws it | | ||
| `rethrow` | `0x09` | relative_depth : `varuint32` | throws the exception caught by the catch block at `relative_depth` | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm it looks like the remnants of the pre-legacy proposal that preceded the legacy proposal. Thanks for the catch. |
||
|
||
The *sig* fields of `block`, `if`, and `try` operators are block signatures | ||
which describe their use of the operand stack. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks the old text is a copy-pasta of
catch
description...