Cleanup

mlir/include/mlir/Dialect/Tosa/Transforms/TosaFoldCommon.h

@@ -20,26 +20,26 @@
 namespace mlir {
 namespace tosa {
 
-// Transform a tensor with the given transformation function.
+/// Transform a tensor with the given transformation function.
 DenseElementsAttr applyElementWise(
     const DenseElementsAttr &toTransform,
     const std::function<llvm::APFloat(const llvm::APFloat &, Type)> &toApply);
 
-/// Function that checks if arg is a dense TOSA constant float tensor
+/// Function that checks if \p toCheck is a dense TOSA constant float tensor.
 LogicalResult notifyIfNotConstantFloatTosaTensor(TypedValue<TensorType> toCheck,
                                                  TosaOp location,
                                                  PatternRewriter &);
 
-/// Function that checks if arg is a dense TOSA constant tensor
+/// Function that checks if \p toCheck is a dense TOSA constant tensor.
 LogicalResult notifyIfNoTosaDenseConstantTensor(TypedValue<TensorType> toCheck,
                                                 TosaOp location,
                                                 PatternRewriter &);
 
-/// Function that checks if the contained type is float
+/// Function that checks if the type contained in \p toCheck is float.
 LogicalResult notifyIfNotFloat(TypedValue<TensorType> toCheck, TosaOp location,
                                PatternRewriter &);
 
-/// Function to compute the reciprocal
+/// Function to compute the reciprocal.
 APFloat computeReciprocal(const APFloat &, Type);
 
 } // namespace tosa

mlir/lib/Dialect/Tosa/Transforms/TosaFoldCommon.cpp

@@ -34,11 +34,11 @@ DenseElementsAttr mlir::tosa::applyElementWise(
   // all of them to avoid dynamic resizing
   transformedValues.reserve(toTransform.getNumElements());
   for (auto val : toTransform.getValues<llvm::APFloat>()) {
-    auto recipVal = toApply(val, toTransform.getElementType());
-    transformedValues.push_back(recipVal);
+    auto transformedVal = toApply(val, toTransform.getElementType());
+    transformedValues.push_back(transformedVal);
   }
 
-  // Replace the current tensor with one containing the computed reciprocals
+  // Replace the current tensor with one containing the computed values
   auto newTensor =
       DenseElementsAttr::get(toTransform.getType(), transformedValues);
   return newTensor;