Feat: add support for Dictionary and Array attributes in PDLL rewrite sections. #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-luecke
requested changes
Jun 20, 2023
There was a problem hiding this comment.
Thank you for looking at this! I added a few thoughts.
I think it would make sense to take some time to figure out how to make the PDLL language server type checking and code completion aware of this. I think this should not be that complicated. There are many references to code_complete tokens flying around in the PDLL parser.
Currently there are only tests for MLIR code generation. I think we also need tests for the PDLL parser, i.e. here
- add parser tests
ljfitz
requested changes
Jun 20, 2023
martin-luecke
approved these changes
Jun 21, 2023
ljfitz
approved these changes
Jun 22, 2023
mgehre-amd
deleted the
tiagot.FXML-2223.FXML-2293.PDLL_array_dict_attrs
branch
mgehre-amd
pushed a commit
that referenced
this pull request
Sep 20, 2024
) Currently, process of replacing bitwise operations consisting of `LSR`/`LSL` with `And` is performed by `DAGCombiner`. However, in certain cases, the `AND` generated by this process can be removed. Consider following case: ``` lsr x8, x8, #56 and x8, x8, #0xfc ldr w0, [x2, x8] ret ``` In this case, we can remove the `AND` by changing the target of `LDR` to `[X2, X8, LSL #2]` and right-shifting amount change to 56 to 58. after changed: ``` lsr x8, x8, #58 ldr w0, [x2, x8, lsl #2] ret ``` This patch checks to see if the `SHIFTING` + `AND` operation on load target can be optimized and optimizes it if it can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the creation of Array and Dictionary attributes in PDLL rewrite sections.
The solution instructs PDLL parser to generate calls to
apply_native_rewriteoperation that can be used to integrate C++ code into PDLL. For that reason, users of this functionality are required to provide C++ implementations of these functions, as well as link and register them in passes that process PDLL files.Functions that need to be implemented are:
createDictionaryAttr(PatternRewriter &rewriter): creates and returns an attribute that represents a dictionary.addEntryToDictionaryAttr (PatternRewriter &rewriter, Attribute attr, Attribute attrName, Attribute attrEntry): add an entry to the dictionary and returns the new dictionary.createArrayAttr(mlir::PatternRewriter &rewriter): creates and returns an attribute that represents an array.addElemToArrayAttr(PatternRewriter &rewriter, Attribute attr, Attribute element): add an element attribute to the array and returns the new array.