Skip to content

Line exclude regex just for keyword detector #131

Closed
@KevinHock

Description

@KevinHock

In #127 we added a line exclude for all plugins and reverted 15a6e6a, which was a line exclude regex for just the high-entropy plugins, this was partially due to imagined use-cases of things someone may want to exclude from all plugins e.g. lines whose first non-whitespace character is a#, and general cleanliness (DRY).

The keyword detector however, is a young plugin with kind of an ambitious goal, and users shouldn't have to add to the FALSE_POSITIVES dict things that may be specific to their codebases, and version bumps won't need to happen to trim false positives.

This is a good-first-issue, b/c it was done very similarly in 15a6e6a

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueThe issue can be tackled by someone who has little to no knowledge about the project.help wantedIndicates that we would like someone that’s not a maintainer to work on the issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions