Makefile: Test yosys git status in check-git-abc #4969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in #4986, `check-git-abc` is misleading if Yosys itself isn't a git repository. So check `git status` before suggesting `git` based solutions, providing alternative suggestions for using ABCEXTERNAL (which bypasses `check-git-abc`), or downloading release tar (noting that the 'Source code' archives won't work, which is probably how they ended up in this situtation).
mmicko
requested changes
Apr 24, 2025
For some platforms (Arch Linux, at least), `git status` reports errors on stdout instead of stderr, so we need to redirect that to `/dev/null` too. This also prevents `git status` from logging output when the yosys directory is a git repo, but is missing the abc folder.
KrystalDelusion
added
the
merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
As in #4968,
check-git-abcis misleading if Yosys itself isn't a git repository.Explain how this is achieved.
So check
git statusbefore suggestinggitbased solutions, providing alternative suggestions for using ABCEXTERNAL (which bypassescheck-git-abc), or downloading release tar (noting that the 'Source code' archives won't work, which is probably how they ended up in this situtation).If applicable, please suggest to reviewers how they can test the change.
Applying patch to release yosys.tar.gz and running
make check-git-abcshould be be unaffected (i.e. should still succeed).Applying patch to release source code archive and running
make check-git-abc(or removing contents of abc folder from yosys.tar.gz) should give new error message.Applying patch to either archive, and deleting abc folder should give new error message.
All other cases should be unaffected.