Skip to content

PR fixes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mydea
Copy link

@mydea mydea commented Feb 5, 2025

I merged in latest develop, but more importantly I fixed the CDN bundle tests here: 67b7b0b, which was the missing piece for CI :)

Lms24 and others added 7 commits February 4, 2025 12:00
Due to a change in the lifecycle of Svelte
components in Svelte 5 (using Rune mode), our SDK can no longer leverage
the `(before|after)Update` hooks to track component update spans.
For v9, this patch therefore disables update tracking by default.
Removes a no longer necessary fallback check that we only needed in
SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the
`event.isSubRequest` flag to identify sub vs. actual requests in our
request handler.

fixes #15244
- adds a toolbar for cropping and annotations
- changes from inline styles to multiple class names in BEM format

With annotation option:
![Screenshot 2025-02-03 at 3 51
04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38)

Without annotation option (to confirm that it looks the same as before):
![Screenshot 2025-02-03 at 5 09
01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349)

Closes #15252
…15288)

The debugging ability for Azure Functions when using Azure Static Web
Apps is very limited. But as I could see some Sentry-related logs I
**think** Sentry is generally initialized.

However, server-related logs don't show up in Sentry. This is
**probably** because the Azure Function finishes before the error can be
sent to Sentry.
By adding the Azure environment variable to check whether we should
flush with a timeout, this should possibly fix the issue.

Logs in Application Insights:

![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)
@@ -1,12 +1,14 @@
import * as Sentry from '@sentry/browser';
// Must import this like this to ensure the test transformation for CDN bundles works
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't aware of that, thanks!

@Zen-cronic Zen-cronic merged commit c8f69fe into Zen-cronic:feat/graphqlClientIntegration Feb 5, 2025
33 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants