Skip to content

Update dns api to support v2 wildcard cert #1261

Open
@Neilpang

Description

@Neilpang

To support v2 wildcard cert, we need to add 2 txt records for the same domain.
for example:

_acme-challenge.example.com   TXT   "this is txt value 1"
_acme-challenge.example.com   TXT   "this is txt value 2"

In many dns api hooks, in the dns_xx_add() function, they try to UPDATE the existing txt record, instead of ADD a new record.
This was a good practice for ACME v1, but it's not good in ACME v2.

In ACME v2, we just need to add new txt record all the time in the dns_xx_add() function,
And in the the dns_xx_rm() function, we must delete the txt record according to the specified txt value.

Test example:

acme.sh  --issue --test  -d example.com  -d *.example.com

Please make sure this works, and the 2 txt records are removed after the cert is issued.

See my changes:

ea25492#diff-51fe23dd1a90a481487dbca5b9c3ae24

72f54ca#diff-d48ca70b90232acffb2b5b9d1ec2938a

584fb29#diff-f272833bc0ccf326ea343539e829f1d3

  • dns_ad
  • dns_ali
  • dns_azure
  • dns_cloudns
  • dns_dnsimple
  • dns_freedns
  • dns_gandi_livedns
  • dns_me
  • dns_nsone
  • dns_pdns
  • dns_unoeuro

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions